From 8960a285f755140cea7a756999d0591622a46f0d Mon Sep 17 00:00:00 2001 From: Flokke Date: Thu, 7 May 2026 09:36:03 +0200 Subject: [PATCH] Remove unnecessary IRAM_ATTR from non-ISR functions --- src/InterruptHandler.cpp | 2 +- src/PiepMode.cpp | 8 ++++---- src/PiepPattern.cpp | 6 +++--- src/Receivers433/ReceiverFunkThermometer.cpp | 8 ++++---- src/Receivers433/ReceiverSmartWares.cpp | 8 ++++---- .../Receivers3ByteKeys/Receiver3ByteKey.cpp | 10 +++++----- 6 files changed, 21 insertions(+), 21 deletions(-) diff --git a/src/InterruptHandler.cpp b/src/InterruptHandler.cpp index 594ac04..6561de4 100644 --- a/src/InterruptHandler.cpp +++ b/src/InterruptHandler.cpp @@ -88,7 +88,7 @@ static IRAM_ATTR void pinLevelChangeIsr(void) portYIELD_FROM_ISR(woken); } -IRAM_ATTR void InterruptHandler_Stop(void) +void InterruptHandler_Stop(void) { timerAlarmDisable(timer); detachInterrupt(digitalPinToInterrupt(DIN_FUNK)); diff --git a/src/PiepMode.cpp b/src/PiepMode.cpp index 0062404..4166e7e 100644 --- a/src/PiepMode.cpp +++ b/src/PiepMode.cpp @@ -41,7 +41,7 @@ PiepMode::PiepMode() /** * */ -IRAM_ATTR void PiepMode::Start(uint8_t outPin) +void PiepMode::Start(uint8_t outPin) { startRequest = true; this->outPin = outPin; @@ -53,7 +53,7 @@ IRAM_ATTR void PiepMode::Start(uint8_t outPin) /** * */ -IRAM_ATTR void PiepMode::Stop() +void PiepMode::Stop() { stopRequest = true; TONE_REQUEST_OFF(TONE_REQUEST_SOURCE_MODE); @@ -63,7 +63,7 @@ IRAM_ATTR void PiepMode::Stop() /** * */ -IRAM_ATTR bool PiepMode::HasCompleted(void) +bool PiepMode::HasCompleted(void) { return (state == STANDBY); } @@ -72,7 +72,7 @@ IRAM_ATTR bool PiepMode::HasCompleted(void) /** * */ -IRAM_ATTR void PiepMode::TaskCyclic() +void PiepMode::TaskCyclic() { switch (state) { diff --git a/src/PiepPattern.cpp b/src/PiepPattern.cpp index 86023d6..e390aa3 100644 --- a/src/PiepPattern.cpp +++ b/src/PiepPattern.cpp @@ -33,7 +33,7 @@ PiepPattern::PiepPattern() /** * */ -IRAM_ATTR void PiepPattern::Start(uint8_t outPin) +void PiepPattern::Start(uint8_t outPin) { startRequest = true; this->outPin = outPin; @@ -44,7 +44,7 @@ IRAM_ATTR void PiepPattern::Start(uint8_t outPin) /** * */ -IRAM_ATTR void PiepPattern::Stop() +void PiepPattern::Stop() { stopRequest = true; } @@ -53,7 +53,7 @@ IRAM_ATTR void PiepPattern::Stop() /** * */ -IRAM_ATTR void PiepPattern::TaskCyclic() +void PiepPattern::TaskCyclic() { switch (state) { diff --git a/src/Receivers433/ReceiverFunkThermometer.cpp b/src/Receivers433/ReceiverFunkThermometer.cpp index 1eeed5a..c7d5d2f 100644 --- a/src/Receivers433/ReceiverFunkThermometer.cpp +++ b/src/Receivers433/ReceiverFunkThermometer.cpp @@ -51,7 +51,7 @@ ReceiverFunkThermometerData_t ReceiverFunkThermometer::GetData(void) /** * */ -IRAM_ATTR void ReceiverFunkThermometer::Isr(uint32_t dtMicros, bool pinValue) +void ReceiverFunkThermometer::Isr(uint32_t dtMicros, bool pinValue) { static SignalDurationThermometer_t lastDuration = FUNK_THERMO_INVALID; SignalDurationThermometer_t thisDuration = FUNK_THERMO_INVALID; @@ -137,7 +137,7 @@ IRAM_ATTR void ReceiverFunkThermometer::Isr(uint32_t dtMicros, bool pinValue) /** * */ -IRAM_ATTR void ReceiverFunkThermometer::ResetBuffer(void) +void ReceiverFunkThermometer::ResetBuffer(void) { rByteIndex = 0; @@ -149,7 +149,7 @@ IRAM_ATTR void ReceiverFunkThermometer::ResetBuffer(void) /** * */ -IRAM_ATTR void ReceiverFunkThermometer::NextByte(void) +void ReceiverFunkThermometer::NextByte(void) { rByteIndex++; rBitIndex = 7; @@ -271,7 +271,7 @@ iiiiiiii tttttttt ttttffff hhhhhhhh */ -IRAM_ATTR void ReceiverFunkThermometer::OnTempReceived(void) +void ReceiverFunkThermometer::OnTempReceived(void) { /* first 4 bits of 36 bits are thrown away.. Rest : diff --git a/src/Receivers433/ReceiverSmartWares.cpp b/src/Receivers433/ReceiverSmartWares.cpp index e8ed48b..28e5280 100644 --- a/src/Receivers433/ReceiverSmartWares.cpp +++ b/src/Receivers433/ReceiverSmartWares.cpp @@ -75,7 +75,7 @@ ReceiverSmartWares::ReceiverSmartWares() /** * */ -IRAM_ATTR void ReceiverSmartWares::Isr(uint32_t dtMicros, bool pinValue) +void ReceiverSmartWares::Isr(uint32_t dtMicros, bool pinValue) { static SignalDuration_t lastDuration = INVALID; SignalDuration_t thisDuration = INVALID; @@ -146,7 +146,7 @@ IRAM_ATTR void ReceiverSmartWares::Isr(uint32_t dtMicros, bool pinValue) /** * */ -IRAM_ATTR void ReceiverSmartWares::ResetBuffer() +void ReceiverSmartWares::ResetBuffer() { rByteIndex = 0; rBitIndex = 7; @@ -157,7 +157,7 @@ IRAM_ATTR void ReceiverSmartWares::ResetBuffer() /** * */ -IRAM_ATTR void ReceiverSmartWares::NextByte() +void ReceiverSmartWares::NextByte() { rByteIndex++; rBitIndex = 7; @@ -176,7 +176,7 @@ IRAM_ATTR void ReceiverSmartWares::NextByte() /** * */ -IRAM_ATTR void ReceiverSmartWares::compareKeys() +void ReceiverSmartWares::compareKeys() { int8_t keyFound = -1; uint8_t i,j; diff --git a/src/Receivers433/Receivers3ByteKeys/Receiver3ByteKey.cpp b/src/Receivers433/Receivers3ByteKeys/Receiver3ByteKey.cpp index 537e5f2..9475afd 100644 --- a/src/Receivers433/Receivers3ByteKeys/Receiver3ByteKey.cpp +++ b/src/Receivers433/Receivers3ByteKeys/Receiver3ByteKey.cpp @@ -34,7 +34,7 @@ Receiver3ByteKey::Receiver3ByteKey() /** * */ -IRAM_ATTR void Receiver3ByteKey::Isr(uint32_t dtMicros, bool pinValue) +void Receiver3ByteKey::Isr(uint32_t dtMicros, bool pinValue) { SignalDuration_t thisDuration = INVALID; @@ -98,7 +98,7 @@ IRAM_ATTR void Receiver3ByteKey::Isr(uint32_t dtMicros, bool pinValue) /** * */ -IRAM_ATTR void Receiver3ByteKey::ResetBuffer() +void Receiver3ByteKey::ResetBuffer() { rByteIndex = 0; rBitIndex = 7; @@ -109,7 +109,7 @@ IRAM_ATTR void Receiver3ByteKey::ResetBuffer() /** * */ -IRAM_ATTR void Receiver3ByteKey::NextBit() +void Receiver3ByteKey::NextBit() { if (rBitIndex == 0) { @@ -124,7 +124,7 @@ IRAM_ATTR void Receiver3ByteKey::NextBit() /** * */ -IRAM_ATTR void Receiver3ByteKey::NextByte() +void Receiver3ByteKey::NextByte() { rByteIndex++; rBitIndex = 7; @@ -143,7 +143,7 @@ IRAM_ATTR void Receiver3ByteKey::NextByte() /** * */ -IRAM_ATTR void Receiver3ByteKey::compareKeys() +void Receiver3ByteKey::compareKeys() { int8_t keyFound = -1; bool direction = false;